Fixes #6603 - HTTP/2 max local stream count exceeded (#6639) #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Wilkins <gregw@webtide.com>
|
@sbordet I fixed the broken test that was due to a change in the dump format |
lorban
previously approved these changes
Aug 31, 2021
lorban
approved these changes
Aug 31, 2021
| @@ -834,6 +837,9 @@ protected IStream createRemoteStream(int streamId, MetaData.Request request) | |||
| int maxCount = getMaxRemoteStreams(); | |||
| if (maxCount >= 0 && remoteCount - remoteClosing >= maxCount) | |||
| { | |||
| IllegalStateException failure = new IllegalStateException("Max remote stream count " + maxCount + " exceeded: " + remoteCount + "+" + remoteClosing); | |||
There was a problem hiding this comment.
This exception is only used in the debug log. We could save a few cycles when this error condition occurs by only creating it if debug is enabled.
gregw
approved these changes
Aug 31, 2021
sbordet
deleted the
jetty-10.0.x-6603-max-concurrent-streams-exceeded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made MAX_CONCURRENT_STREAMS setting work on a per-connection basis.
Updated Pool javadocs.
Signed-off-by: Simone Bordet simone.bordet@gmail.com
Co-authored-by: Greg Wilkins gregw@webtide.com
(cherry picked from commit 525fcb3)