Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7059 - prevent an internal NPE in AllowedResourceAliasChecker doStart #7076

Merged
merged 9 commits into from
Dec 6, 2021
Merged

Issue #7059 - prevent an internal NPE in AllowedResourceAliasChecker doStart #7076

merged 9 commits into from
Dec 6, 2021

Conversation

lachlan-roberts
Copy link
Contributor

Issue #7059

  • Return null from AllowedResourceAliasChecker.getPath() if base resource is null without throwing and catching NPE.
  • Do not allow base resource to be set after the ContextHandler is started.

@lachlan-roberts
Issue #7059 - prevent an internal NPE in AllowedResourceAliasChecker …
59b9d4f 
…doStart

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Fix tests failing due to ContextHandler.setBaseResource() change
3b1af76 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Issue #7059 - Fix LifeCycle issues with AllowedResourceAliasChecker
1eb933e 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
fix broken test in ServletLifeCycleTest
c466eed 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Issue #7059 - add null check for protected targets in toString.
23594e2 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw previously approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lachlan-roberts
Issue #7059 - use ArrayList instead of CopyOnWriteArrayList for Alias…
511fe0d 
…Checkers

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from gregw November 5, 2021 00:50
@lachlan-roberts lachlan-roberts mentioned this pull request Nov 5, 2021
Merged
@lachlan-roberts
improve warning message for AllowedResourceAliasChecker
73350c1 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw previously approved these changes Nov 10, 2021
View reviewed changes
@lachlan-roberts
Issue #7059 - add AllowedResourceAliasCheckerTest
b2a1c90 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
minor changes to make same as PR to 9.4
37bc983 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts merged commit e345ee2 into jetty-10.0.x Dec 6, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-7059-AllowedResourceAliasChecker-NPE branch December 6, 2021 22:37
@lachlan-roberts lachlan-roberts mentioned this pull request Dec 6, 2021
Closed
@madrob madrob mentioned this pull request Feb 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@gregw gregw gregw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lachlan-roberts @gregw @joakime