-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8014 - Review HttpRequest URI construction. #8015
Conversation
Now always adding a "/" before the path, if not already present. Disabled flakey HTTP/3 test. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@simone, i think we should also fix the asString method in HttpURI. I know it's not used, but it makes the same mistake with non root paths. |
Fixes after review in HttpURI. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the IllegalArgumentExceptions on this
More fixes after review in HttpURI. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OPTIONS path of *
makes this interesting for sure.
isPathValidForAuthority(String)
method makes this much easier to understand now too.
Note, I'm working on fixing the test failure on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable change.
Lets see what the CI build/test shows.
The CI failure was an unrelated problem with a repository. Retrying... |
Still having CI issues... which I think are unrelated. If I get a clean build (again) locally, I will merge. |
…4.48.v20220622 ### What changes were proposed in this pull request? Upgrade `jetty-http` from 9.4.46.v20220331 to 9.4.48.v20220622 ### Why are the changes needed? [Release note](https://github.com/eclipse/jetty.project/releases) [CVE-2022-2047](https://nvd.nist.gov/vuln/detail/CVE-2022-2047) Info from Github dependabot ### Invalid URI parsing may produce invalid HttpURI.authority ### Description URI use within Jetty's `HttpURI` class can parse invalid URIs such as `http://localhost;/path` as having an authority with a host of `localhost;`. A URIs of the type `http://localhost;/path` should be interpreted to be either invalid or as `localhost;` to be the userinfo and no host. However, `HttpURI.host` returns `localhost;` which is definitely wrong. ### Impact This can lead to errors with Jetty's `HttpClient`, and Jetty's `ProxyServlet` / `AsyncProxyServlet` / `AsyncMiddleManServlet` wrongly interpreting an authority with no host as one with a host. ### Patches Patched in PR jetty/jetty.project#8146 for Jetty version 9.4.47. Patched in PR jetty/jetty.project#8015 for Jetty versions 10.0.10, and 11.0.10 ### Workarounds None. ### For more information If you have any questions or comments about this advisory: Email us at [securitywebtide.com](mailto:securitywebtide.com)." ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes #37142 from bjornjorgensen/jetty-http-9.4.48.v20220622. Lead-authored-by: Bjørn Jørgensen <bjornjorgensen@gmail.com> Co-authored-by: Bjorn Jorgensen <bjornjorgensen@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Now always adding a "/" before the path, if not already present.
Disabled flakey HTTP/3 test.
Signed-off-by: Simone Bordet simone.bordet@gmail.com