Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RetainableByteBufferPool a 1st class citizen in the API #8169

Closed

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jun 15, 2022

No description provided.

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this.... could we consider doing this more like ThreadPool and ReservedThreadPool, where we just have a single pool that can be used in either way?

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@gregw gregw mentioned this pull request Jun 16, 2022
@gregw
Copy link
Contributor

gregw commented Jun 29, 2022

Whilst there might be more work to do on #8171, I think it is a much better approach than this..... so closing this one.

@gregw gregw closed this Jun 29, 2022
@joakime joakime deleted the jetty-10.0.x-8161-improve-retainable-bb-integration branch July 13, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants