-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8863 - Provide a possibility to name virtual threads #8903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a release with the old method names?
If so, this can't be removed, only deprecated.
jetty-http-spi/src/main/java/org/eclipse/jetty/http/spi/DelegatingThreadPool.java
Show resolved
Hide resolved
jetty-http-spi/src/main/java/org/eclipse/jetty/http/spi/DelegatingThreadPool.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love it, as it is similar yet different to the pattern we've applied for TryExecutor.
Was there a reason we didn't just invent our own interface like:
interface VirtualExecutor
{
void executeVirtually(Runnable task);
}
So we could follow the pattern of TryExecutor ?
Executor executor = _virtualThreadsExecutor; | ||
if (executor == null) | ||
executor = _executor; | ||
executor.execute(task); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a little strange that we have both an _executor and a _virtualThreadsExecutor, but use one or the other.
I guess we need the _executor when running with virtual threads and reserved threads, so the reserved threads can be started by the normal executor.
It would be nice if it could more closely resemble the _tryExecutor pattern.
@gregw For virtual threads is different, we want to give users a way to pass their own virtual We want also to support a "simple" way to configure this in Jetty modules. WRT to Even if from I think we need 2 |
Now <Call>, <Get> and <Set> elements can use the "class" attribute to specify the exact class to perform method lookup. Improved support for <Property>, <SystemProperty> and <Env> so that attribute "name" is now optional (as specified in the DTD), and a "deprecated" attribute may be present instead. This is necessary to terminally deprecate properties that have no replacement. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Reworked the VirtualThreads APIs to be based on Executor rather than just boolean. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
4e1eac4
to
01ca480
Compare
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Reworked the VirtualThreads APIs to be based on Executor rather than just boolean.
Signed-off-by: Simone Bordet simone.bordet@gmail.com