Jetty 12 mimetype cleanup #8919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Wilkins <gregw@webtide.com>
…leanup' into jetty-12-mimetype-cleanup # Conflicts: # jetty-ee9/jetty-ee9-servlets/src/main/java/org/eclipse/jetty/ee9/servlets/IncludeExcludeBasedFilter.java
lachlan-roberts
requested changes
Nov 21, 2022
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/Response.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java
Outdated
Show resolved
Hide resolved
joakime
requested changes
Nov 21, 2022
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java
Show resolved
Hide resolved
…type-cleanup # Conflicts: # jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipHandlerTest.java
…-jdk-20' into jetty-12-mimetype-cleanup
…-jdk-20' into jetty-12-mimetype-cleanup
…type-cleanup # Conflicts: # jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipHandlerTest.java
janbartel
approved these changes
Nov 21, 2022
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/MimeTypes.java
Outdated
Show resolved
Hide resolved
| @@ -30,6 +30,8 @@ public static Stream<Arguments> mimeTypesByExtensionCases() | |||
| { | |||
| return Stream.of( | |||
| Arguments.of("test.gz", "application/gzip"), | |||
| Arguments.of("test.tar.gz", "application/gzip"), | |||
| Arguments.of("test.tgz", "application/x-gtar"), | |||
There was a problem hiding this comment.
This is deliberate, yes? You removed type application/x-gtar from mime.properties ...
There was a problem hiding this comment.
Correct. Aligning with common extension handling practice of just looking at the final dot segment. This is more efficient, same as most other projects and there is only one extension we had with a dot in it.
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/FileID.java
Outdated
Show resolved
Hide resolved
joakime
reviewed
Nov 23, 2022
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/Response.java
Show resolved
Hide resolved
joakime
approved these changes
Nov 23, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup a bunch of TODOs related to MimeType lookup.
Primarily
MimeTypesare now available via theContext.