Cleanup of TypeUtil and ContextHandler stop/start #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ TypeUtil class shortname used more often and includes trailing digits + Fixed direct stopping/starting of a nested ContextHandler + Fixed null path handling in nested context + more tests for all of the above
Fixed nested doStart and doStop
|
@joakime @lachlan-roberts the CI failure is a java-19 flake. Can you please review rather than wait for a green build. |
Fixed DistributionTests
gregw
changed the title
janbartel
approved these changes
Dec 6, 2022
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/ContextHandler.java
Show resolved
Hide resolved
| @@ -490,7 +490,7 @@ public void testBaseResourceAbsolutePath() throws Exception | |||
| // On Unix / Linux this should have no issue. | |||
| // On Windows with fully qualified paths such as "E:\mybase\webapps\dump.war" the | |||
| // resolution of the Resource can trigger various URI issues with the "E:" portion of the provided String. | |||
| context.setResourceBase(warPath.toString()); | |||
| context.setBaseResourceAsString(warPath.toString()); | |||
There was a problem hiding this comment.
FYI again, I think this is also part of 2 other PRs.
olamy
approved these changes
Dec 6, 2022
| @@ -141,6 +141,44 @@ public void testSimpleGET() throws Exception | |||
| assertThat(BufferUtil.toString(stream.getResponseContent()), equalTo(helloHandler.getMessage())); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testNullPath() throws Exception | |||
There was a problem hiding this comment.
I don't understand why we need processMovedPermanently and processByContextHandler both in ContextHandler one sends a 301 and other sends 302 response.
There was a problem hiding this comment.
I don't think we do. I've removed processByContextHandler in #8978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully non controversial changes from monster PR: