use service loader with gziphandler #9199
Conversation
jimexist
commented
Jan 23, 2023
jimexist
commented
- closes Introduce CompressionHandler to support compression from gzip, brotli, and zstandard #8769
|
There's no test cases show how this would be used. Can you create a ExampleCompression whatever in the src/test/java and src/test/resources/META-INF/services/ to show it working? The compression doesn't have to do actual compression, heck, make it just ROT13 for purposes of the test. (that way we can see it performing the transformation and back again) |
| @@ -876,7 +878,7 @@ public void handle(String target, Request baseRequest, HttpServletRequest reques | |||
| shopContext.setHandler(new ShopHandler()); | |||
|
|
|||
| // You want to gzip the shop web application only. | |||
| GzipHandler shopGzipHandler = new GzipHandler(); | |||
| DynamicCompressionHandler shopGzipHandler = ServiceLoader.load(DynamicCompressionHandler.class).iterator().next(); | |||
There was a problem hiding this comment.
I can't see the benefit of using the ServiceLoader this way. A user can just extend GzipHandler and then call ServletContextHandler.setGzipHandler.
Can you explain the problem you're trying to solve a bit more?
There was a problem hiding this comment.
specific approach inspired by original issue #8769 but personally i think it's okay to have it either way as long as interface is consistent
|
Sorry we have not acted on this PR for while. Busy month. |
