Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override default CORS handler for httprouter #102

Merged
merged 8 commits into from
Aug 12, 2020
Merged

override default CORS handler for httprouter #102

merged 8 commits into from
Aug 12, 2020

Conversation

Alma-media
Copy link
Member

@Alma-media Alma-media commented Aug 12, 2020

Related to #74

Includes support for:

  • Access-Control-Allow-Origin
  • Access-Control-Request-Method
  • Access-Control-Request-Headers

Other changes:

  • introduce ListenerOption

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.29%.
The diff coverage is 89.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   83.27%   83.57%   +0.29%     
==========================================
  Files          65       68       +3     
  Lines        4276     4317      +41     
==========================================
+ Hits         3561     3608      +47     
  Misses        448      448              
+ Partials      267      261       -6     
Impacted Files Coverage Δ
pkg/transport/http/options.go 71.64% <ø> (+1.64%) ⬆️
pkg/transport/http/listener_options.go 85.18% <85.18%> (ø)
pkg/transport/http/listener.go 75.71% <87.50%> (+1.85%) ⬆️
pkg/transport/http/middleware.go 100.00% <100.00%> (ø)
pkg/transport/http/unique.go 100.00% <100.00%> (ø)

pkg/transport/http/listener.go Outdated Show resolved Hide resolved
examples/http/config.hcl Outdated Show resolved Hide resolved
pkg/transport/http/http_test.go Outdated Show resolved Hide resolved
cmd/semaphore/config/arguments.go Outdated Show resolved Hide resolved
pkg/transport/http/listener_options_test.go Outdated Show resolved Hide resolved
cmd/semaphore/config/arguments.go Show resolved Hide resolved
@jeroenrinzema jeroenrinzema merged commit 2966656 into master Aug 12, 2020
@jeroenrinzema jeroenrinzema deleted the cors branch August 12, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants