-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf code generator (command) #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 84.46% 84.60% +0.14%
==========================================
Files 70 70
Lines 4409 4398 -11
==========================================
- Hits 3724 3721 -3
+ Misses 425 420 -5
+ Partials 260 257 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new structs
and interfaces
implementations. I just got two small comments.
|
||
func init() { | ||
Command.PersistentFlags().StringSliceVar(¶ms.Protobuffers, "proto", []string{}, "If set are all proto definitions found inside the given path passed as schema definitions, all proto definitions are also passed as imports") | ||
Command.PersistentFlags().StringSliceVarP(¶ms.Files, "file", "f", []string{"config.hcl"}, "Parses the given file as a definition file") | ||
Command.PersistentFlags().StringVar(¶ms.LogLevel, "level", "warn", "Global logging level, this value will override the defined log level inside the file definitions") | ||
Command.PersistentFlags().StringVarP(&output, "output", "o", "", "Output directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is a good idea to add a small warning that all missing directories are created?
Related to #73