Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML encoder implementation #120

Merged
merged 11 commits into from
Sep 7, 2020
Merged

XML encoder implementation #120

merged 11 commits into from
Sep 7, 2020

Conversation

Alma-media
Copy link
Member

@Alma-media Alma-media commented Sep 2, 2020

This PR introduces the ability to encode and decode XML objects.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #120 into master will decrease coverage by 0.60%.
The diff coverage is 78.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   86.70%   86.10%   -0.61%     
==========================================
  Files          89       98       +9     
  Lines        5166     5425     +259     
==========================================
+ Hits         4479     4671     +192     
- Misses        426      474      +48     
- Partials      261      280      +19     
Impacted Files Coverage Δ
pkg/codec/json/object.go 83.09% <ø> (+0.69%) ⬆️
pkg/codec/www-form-urlencoded/errors.go 100.00% <ø> (ø)
pkg/codec/www-form-urlencoded/types.go 100.00% <ø> (ø)
pkg/codec/xml/object.go 57.14% <57.14%> (ø)
pkg/codec/xml/xml.go 68.96% <68.96%> (ø)
pkg/codec/json/array.go 81.48% <81.48%> (ø)
pkg/codec/xml/array.go 86.66% <86.66%> (ø)
pkg/codec/xml/decode.go 89.09% <89.09%> (ø)
pkg/codec/xml/encode.go 94.28% <94.28%> (ø)
pkg/codec/www-form-urlencoded/form.go 92.06% <100.00%> (ø)
... and 12 more

@Alma-media Alma-media marked this pull request as ready for review September 4, 2020 08:38
@jeroenrinzema jeroenrinzema merged commit 3662ebe into master Sep 7, 2020
@jeroenrinzema jeroenrinzema deleted the xml-codec branch September 7, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants