Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JSON specs support #170

Merged
merged 5 commits into from
Dec 3, 2020

Conversation

jeroenrinzema
Copy link
Contributor

@jeroenrinzema jeroenrinzema commented Dec 2, 2020

This PR includes support for JSON specs. JSON files could be included next to HCL files.

semaphore -f config.hcl -f example.json

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #170 (b9e9342) into master (7a85a9b) will decrease coverage by 2.27%.
The diff coverage is 77.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   82.23%   79.96%   -2.28%     
==========================================
  Files         144      157      +13     
  Lines        6385     6717     +332     
==========================================
+ Hits         5251     5371     +120     
- Misses        761      959     +198     
- Partials      373      387      +14     
Impacted Files Coverage Δ
cmd/semaphore/daemon/providers/options.go 93.10% <0.00%> (-6.90%) ⬇️
cmd/semaphore/functions/strings/sprintf/sprintf.go 95.00% <0.00%> (ø)
pkg/broker/manager/flow.go 0.00% <0.00%> (ø)
pkg/broker/manager/options.go 0.00% <0.00%> (ø)
pkg/codec/xml/errors.go 100.00% <ø> (+10.00%) ⬆️
pkg/flow/flow.go 98.73% <0.00%> (ø)
pkg/providers/errors.go 100.00% <ø> (ø)
pkg/specs/flows.go 94.64% <0.00%> (-3.51%) ⬇️
pkg/specs/services.go 100.00% <ø> (ø)
pkg/transport/protocol.go 100.00% <ø> (ø)
... and 74 more

@jeroenrinzema jeroenrinzema merged commit 4ebbfa9 into jexia:master Dec 3, 2020
@jeroenrinzema jeroenrinzema deleted the feat/specs-provider branch December 3, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants