Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: append default GEM_PATH #55

Closed
wants to merge 3 commits into from
Closed

Fix: append default GEM_PATH #55

wants to merge 3 commits into from

Conversation

funal125
Copy link

I have tested it on jruby 1.7.6 and 1.6.8 also. they suffer the same issue.
Although jruby just has two default gems(jruby-launcher and rake).

I think the best way is add the default GEM_PATH back.
And I also try to remove the .gem in GEM_PATH

@jf
Copy link
Owner

jf commented Nov 27, 2013

I think this would probably be the better fix. I dont even know why the default GEM_PATH was taken out. Probably in an attempt to let everything be defined in gemsets? and then I guess after that the "global" gemset request came in, to try to be that sort of "default fallback" (as far as I can tell, this is the order as things happened: #16, #18, #20). I personally would prefer to have the standard GEM_PATH added back in (see also #33).

Now having said all that.... I disagree with the implementation as done here. I dont want to call out to ruby just to get the standard GEM_PATH! (Hint: you should be using 'gem env gemdir' instead! as I alluded to in #33) You could then achieve this with a one-liner.

@funal125
Copy link
Author

Ok, I got it.
Thanks a lot

@jf
Copy link
Owner

jf commented Nov 27, 2013

are you going to submit another pull request, Felix?

@funal125
Copy link
Author

Now, we can use DEFAULT to include all default gems, this is especially useful for rubinius and jruby.
And I also remove .gem from GEM_PATH

@jf
Copy link
Owner

jf commented Nov 27, 2013

No.

@jf jf closed this Nov 27, 2013
@jf jf reopened this Nov 27, 2013
@jf
Copy link
Owner

jf commented Nov 27, 2013

thanks, but I'm done with this pull request. a91d8af ... (leaving the version bump) is what I wanted.

@jf jf closed this Nov 27, 2013
@funal125
Copy link
Author

I like your version.
Thanks a lot.

Now, i can go back to work with rubinius.

@jf
Copy link
Owner

jf commented Nov 27, 2013

As mentioned in the commit, thanks for not letting go of this! you've convinced me to add the standard gem path back in; and I'm sure a lot of people will be happy with this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants