-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for mobile scrollable tables #49
Conversation
Before testing it out on mobile I wanted to make sure everything looked fine as before on desktop, but I found the following issues:
And on mobile I found:
Ran this both on my local machine and a development server, and the results were consistent. |
Line 180 removes the pagination if there is only one page - I added this line while experimenting and forgot to remove it I'll look further into the issues mentioned |
Desktop
Mobile
|
There are some styling issues, but they can be sorted out in another PR and I don't think are a result of this current PR. So I am gonna go ahead and merge this. |
Resolves #31
Root cause analysis revealed that due to conflicting CSS properties on ANTD elements, the table was not rendering properly on mobile devices.
Removing the conflicting CSS yielded a table that spilled out over its parent container. As a result, this pull request includes a hacky solution to dynamically bounding the expenses table within its ancestor elements.
A better long-term solution would involve taking another look at the CSS layout and architecture of the frontend and perhaps overhauling it in the future (see #48).