Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a -hide-private-members flag #110

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

weters
Copy link
Contributor

@weters weters commented Feb 9, 2021

Added a -hide-private-members to hide private fields and methods

@jfeliu007
Copy link
Owner

Hi @weters, thanks for this PR, I have not reviewed this yet because I am having trouble running automation for this repo. Also, was this an issue in the issues section? I am trying to be consistent with how to develop for this repo to make sure everything that is worked on is relevant. This seems to be a nice feature, but could you open an issue for this and reference it here as fixed? Take a look at https://github.com/jfeliu007/goplantuml/blob/master/CONTRIBUTING.md if you have a chance. Again, thanks for contributing, I really appreciate the effort of anyone that wants to be involved.

@jfeliu007
Copy link
Owner

I am going to close this one and reopen it to run the automation. I just fixed it.

@jfeliu007 jfeliu007 closed this Mar 1, 2021
@jfeliu007 jfeliu007 reopened this Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #110 (386ce1a) into master (84f20f5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          509       516    +7     
=========================================
+ Hits           509       516    +7     
Impacted Files Coverage Δ
parser/class_parser.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f20f5...386ce1a. Read the comment docs.

@jfeliu007 jfeliu007 merged commit e70c9fa into jfeliu007:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants