Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add universal_url_prefix for APIManager #431

Closed
wants to merge 5 commits into from

Conversation

elvismacak
Copy link

add a global url_prefix in the apimanager, so no need for user to specify url_prefix in each create_api method

@elvismacak
Copy link
Author

test locally success, but failed remote in travis

elvis added 3 commits April 29, 2015 21:00
@jfinkels
Copy link
Owner

Thanks for your contribution! I have implemented this in a slightly different way in 46c2c2d. I have left the behavior a little bit simpler than what you suggested here: a url_prefix in the create_api() method will simply override the value supplied in the constructor. To allow the more complicated "appending" behavior you suggested here, please open a new pull request with some justification for why that would be valuable.

@jfinkels jfinkels closed this Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants