Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 5 Support #233

Closed
wants to merge 9 commits into from
Closed

Conversation

tarebyte
Copy link

@tarebyte tarebyte commented Nov 13, 2016

👋

Closes #230

I've added Rails 5 and Ruby 2.3.1 to the Travis testing Matrix and added support for Rails 5.

Thanks!

@tarebyte
Copy link
Author

So it looks like something changed in the Travis CI config that stopped selenium from working.

Here is a separate build I ran here: https://travis-ci.org/tarebyte/konacha/builds/175511362 that just added Ruby 2.3.1 to the matrix.

I think there is a bigger issue here, and I'll try to come back to it when I have time.

Sorry for the noise!

@jfirebaugh
Copy link
Owner

Thanks @tarebyte! Sorry about the build failures. It looks like they were due to picking up a new major version release of selenium-webdriver that isn't compatible with something. I don't have time to sort through what the incompatibility is so I just pinned to ~> 2. Want to rebase on master and see if it builds now?

@maletor
Copy link

maletor commented Jan 5, 2017

This looks perfect to me. @jfirebaugh, can we get this merged in and cut a new release?

@jfirebaugh
Copy link
Owner

Sure, but we'll need it to be passing CI first.

@maletor
Copy link

maletor commented Jan 5, 2017

So if re-run master on travis right now it is totally green?

@maletor
Copy link

maletor commented Jan 11, 2017

Anything I can help with @tarebyte?

@tarebyte
Copy link
Author

tarebyte commented Jan 11, 2017

Anything I can help with @tarebyte?

@maletor I kept playing with it, not sure what's up. If you want to take over this PR feel free this isn't very high up on my priority list.

I can give you access to my fork just let me know.

@dpoint01
Copy link

@tarebyte any update on this ?

@tarebyte
Copy link
Author

@dpoint01 this fell off my radar, I'll try and take a look at it soon.

@tarebyte
Copy link
Author

tarebyte commented Mar 3, 2018

Closing this to being stale, apologies for dropping the ball on this.

@tarebyte tarebyte closed this Mar 3, 2018
@tarebyte tarebyte deleted the tarebyte/rails-5 branch March 3, 2018 02:36
lumos-gonz added a commit to lumos-gonz/konacha that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants