-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 5 Support #233
Add Rails 5 Support #233
Conversation
9c00f26
to
f5ac179
Compare
So it looks like something changed in the Travis CI config that stopped selenium from working. Here is a separate build I ran here: https://travis-ci.org/tarebyte/konacha/builds/175511362 that just added Ruby 2.3.1 to the matrix. I think there is a bigger issue here, and I'll try to come back to it when I have time. Sorry for the noise! |
Thanks @tarebyte! Sorry about the build failures. It looks like they were due to picking up a new major version release of selenium-webdriver that isn't compatible with something. I don't have time to sort through what the incompatibility is so I just pinned to |
15eb412
to
e607dda
Compare
This looks perfect to me. @jfirebaugh, can we get this merged in and cut a new release? |
Sure, but we'll need it to be passing CI first. |
So if re-run master on travis right now it is totally green? |
Anything I can help with @tarebyte? |
@tarebyte any update on this ? |
@dpoint01 this fell off my radar, I'll try and take a look at it soon. |
Closing this to being stale, apologies for dropping the ball on this. |
👋
Closes #230
I've added Rails 5 and Ruby 2.3.1 to the Travis testing Matrix and added support for Rails 5.
Thanks!