Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Maven doesn't build jflex on Travis #570

Closed
regisd opened this issue Nov 4, 2019 · 3 comments · Fixed by #569
Closed

[master] Maven doesn't build jflex on Travis #570

regisd opened this issue Nov 4, 2019 · 3 comments · Fixed by #569
Assignees
@regisd

Comments

@regisd
Copy link
Member

regisd commented Nov 4, 2019 

Compile, test and install all
=============================
/home/travis/build/jflex-de/jflex/cup-maven-plugin/src/main/java/jflex/maven/plugin/cup/GenerateMojo.java:5: error: cannot access BufferedReader
import java.io.BufferedReader;
              ^
  bad class file: /modules/java.base/java/io/BufferedReader.class
    class file has wrong version 55.0, should be 53.0
    Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error

https://travis-ci.org/jflex-de/jflex/jobs/582161766
@regisd regisd self-assigned this Nov 4, 2019
@regisd
Copy link
Member Author

regisd commented Nov 5, 2019 •
edited
Loading

The Travis image as been changed from Trusty to Xeniak

instance: travis-job-af52625f-fbc4-42cd-a292-72f4a2922c58 travis-ci-sardonyx-xenial-1553530528-f909ac5 (via amqp)

And this bumps the JDK we receive to

openjdk version "11.0.2" 2019-01-15

@regisd
Copy link
Member Author

regisd commented Nov 5, 2019

The previous successful build was onTrusty with jdk 1.8
https://travis-ci.org/jflex-de/jflex/jobs/555506135

@regisd regisd changed the title master build on Travis master doesn't build on Travis Nov 5, 2019
@regisd regisd changed the title master doesn't build on Travis [master] Maven doesn't build jflex on Travis Nov 5, 2019
@regisd regisd mentioned this issue Nov 5, 2019
Merged
regisd added a commit that referenced this issue Nov 5, 2019
@regisd
Fix the build (#569)
8e95060 
* Fix #570. Build broken on Cirrus by upgrade to Bazel v1.0
  * The `single_file` attribute has been replaced by `allow_single_file`.
    Use **bazel_rules** v4 which fixed this. jflex-de/bazel_rules#13
  * add `--incompatible_depset_union=false`
    bazel_pandoc ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union bazelbuild/bazel#5817
  * Use ProdriveTechnologies/bazel-latex#26 because `run_lualatex.py` is not executable
  * In deps, use `https` rather than `http`
* Fix build broken on Travis due to upgrade to Xenial
  * Use openjdk11 because whatever I ask for, that's what I get.
  * Upgrade maven-compiler-plugin to 3.8.0 to fix _class file has wrong version 55.0, should be 53.0_
  * Fix maven-compiler-plugin config for ErrorProne
  * Fix config of maven-javadoc-plugin for newer JDK. https://bugs.openjdk.java.net/browse/JDK-8212233
  * In aggregated sources, update to JDK8 because Xenial doesn't support JDK7 anymore.
    Add manual dep on **javax-annotations.jar** because because JDK8 doesn't provide it anymore.
  * Remove the task that builds the docs because `\tightlist` is not known. #571
regisd pushed a commit that referenced this issue Nov 5, 2019
@traviscibot
Pseudo-Merge commit 8e95060
13c1e50 
Author: Régis Décamps <regisd@google.com>
Date:   Tue Nov 5 11:16:01 2019 +0100

    Fix the build (#569)

    * Fix #570. Build broken on Cirrus by upgrade to Bazel v1.0
      * The `single_file` attribute has been replaced by `allow_single_file`.
        Use **bazel_rules** v4 which fixed this. jflex-de/bazel_rules#13
      * add `--incompatible_depset_union=false`
        bazel_pandoc ProdriveTechnologies/bazel-pandoc#6 needs to update for incompatible_depset_union bazelbuild/bazel#5817
      * Use ProdriveTechnologies/bazel-latex#26 because `run_lualatex.py` is not executable
      * In deps, use `https` rather than `http`
    * Fix build broken on Travis due to upgrade to Xenial
      * Use openjdk11 because whatever I ask for, that's what I get.
      * Upgrade maven-compiler-plugin to 3.8.0 to fix _class file has wrong version 55.0, should be 53.0_
      * Fix maven-compiler-plugin config for ErrorProne
      * Fix config of maven-javadoc-plugin for newer JDK. https://bugs.openjdk.java.net/browse/JDK-8212233
      * In aggregated sources, update to JDK8 because Xenial doesn't support JDK7 anymore.
        Add manual dep on **javax-annotations.jar** because because JDK8 doesn't provide it anymore.
      * Remove the task that builds the docs because `\tightlist` is not known. #571

Updated from target/jflex-parent-1.8.0-SNAPSHOT-sources.jar
@regisd
Copy link
Member Author

regisd commented Nov 5, 2019

Use openjdk11 because whatever I ask for, that's what I get.
https://travis-ci.community/t/install-jdk-sh-failing-for-openjdk9-and-10/3998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisd regisd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the build regisd/jflex
1 participant
@regisd