correct String.words and String.lines simplifications

CHANGELOG.md

@@ -11,6 +11,10 @@ The rule now simplifies:
 - `List.length (Dict.toList dict)` to `Dict.size dict` (same for `Dict.values` and `Dict.keys`)
 - `List.isEmpty (Dict.toList dict)` to `Dict.isEmpty dict` (same for `Dict.values` and `Dict.keys`)
 
+Bug fixes:
+- Fixed an issue where `String.words ""` would be fixed to `[]`
+- Fixed an issue where `String.lines ""` would be fixed to `[]`
+
 ## [2.1.3] - 2023-10-23
 
 The rule now simplifies:

src/Simplify.elm

@@ -378,10 +378,10 @@ Destructuring using case expressions
     --> "z" -- only when resulting string is unchanged
 
     String.words ""
-    --> []
+    --> [ "" ]
 
     String.lines ""
-    --> []
+    --> [ "" ]
 
     String.reverse ""
     --> ""
@@ -4687,13 +4687,13 @@ stringRepeatChecks =
 stringWordsChecks : IntoFnCheck
 stringWordsChecks =
     intoFnCheckOnlyCall
-        (callOnEmptyReturnsCheck { resultAsString = listCollection.empty.specific.asString } stringCollection)
+        (callOnEmptyReturnsCheck { resultAsString = \_ -> "[ \"\" ]" } stringCollection)
 
 
 stringLinesChecks : IntoFnCheck
 stringLinesChecks =
     intoFnCheckOnlyCall
-        (callOnEmptyReturnsCheck { resultAsString = listCollection.empty.specific.asString } stringCollection)
+        (callOnEmptyReturnsCheck { resultAsString = \_ -> "[ \"\" ]" } stringCollection)
 
 
 stringToListChecks : IntoFnCheck

tests/Simplify/StringTest.elm

@@ -660,20 +660,20 @@ b = String.words str
 """
                     |> Review.Test.run ruleWithDefaults
                     |> Review.Test.expectNoErrors
-        , test """should replace String.words "" by []""" <|
+        , test """should replace String.words "" by [ "" ]""" <|
             \() ->
                 """module A exposing (..)
 a = String.words ""
 """
                     |> Review.Test.run ruleWithDefaults
                     |> Review.Test.expectErrors
                         [ Review.Test.error
-                            { message = "String.words on \"\" will result in []"
-                            , details = [ "You can replace this call by []." ]
+                            { message = "String.words on \"\" will result in [ \"\" ]"
+                            , details = [ "You can replace this call by [ \"\" ]." ]
                             , under = "String.words"
                             }
                             |> Review.Test.whenFixed """module A exposing (..)
-a = []
+a = [ "" ]
 """
                         ]
         ]
@@ -698,12 +698,12 @@ a = String.lines ""
                     |> Review.Test.run ruleWithDefaults
                     |> Review.Test.expectErrors
                         [ Review.Test.error
-                            { message = "String.lines on \"\" will result in []"
-                            , details = [ "You can replace this call by []." ]
+                            { message = "String.lines on \"\" will result in [ \"\" ]"
+                            , details = [ "You can replace this call by [ \"\" ]." ]
                             , under = "String.lines"
                             }
                             |> Review.Test.whenFixed """module A exposing (..)
-a = []
+a = [ "" ]
 """
                         ]
         ]