Improvements to fromList key deduplication simplification #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lue-bird
approved these changes
Dec 28, 2024
| @@ -365,6 +365,26 @@ a = Dict.fromList [ ( key, v0 ), ( key, v1 ) ] | |||
| |> Review.Test.whenFixed """module A exposing (..) | |||
| import Dict | |||
| a = Dict.fromList [ ( key, v1 ) ] | |||
| """ | |||
| ] | |||
| , test "should replace Dict.fromList [ ( key, v0 ), thing, ( key, v1 ) ] by Dict.fromList [ thing, ( key, v1 ) ]" <| | |||
There was a problem hiding this comment.
Really good refactors and fixes.
I keep missing cases like that so I'll try to test on more examples next time :)
There was a problem hiding this comment.
No worries, I only discovered it while refactoring the code and thinking something was odd. Think of what you can, and we can fix based on feedback if necessary 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was a bug where some entries would be removed: We did
Dict.fromList [ ( key, a ), thing, ( key, b ) ] -> Dict.fromList [ ( key, b ) ]which is incorrectly removingthing.Other improvements:
allDifferentchecks now aborts early when finding an errorPR can be reviewed commit by commit.