Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify field access for records and record updates #35

Merged
merged 7 commits into from
Aug 19, 2022

Conversation

miniBill
Copy link
Contributor

Closes #34

Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. I added a few remarks, but I don't think it's too much work.

src/Simplify.elm Outdated Show resolved Hide resolved
src/Simplify.elm Outdated Show resolved Hide resolved
src/Simplify.elm Outdated Show resolved Hide resolved
src/Simplify.elm Show resolved Hide resolved
src/Simplify.elm Outdated Show resolved Hide resolved
Copy link
Owner

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the new simplification! Very nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify field access to records and record updates
2 participants