Add field access simplification for if/then/else #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
requested changes
Aug 20, 2022
|
If merged this would close #33 |
jfmengels
reviewed
Aug 21, 2022
|
Rebased |
|
Hey @miniBill I'm not sure what the state of this PR is. I don't think the direction this is heading towards is the one. I think that this would make sense if we notice that in every branch, we can end up simplifying the pattern, but not otherwise. What do you think? |
|
It seems like a reasonable restriction! It's uniform, non-surprising, and should have very few false positives! |
|
Ok, I've restricted the simplification to the case where all leaves are records, record updates or record accesses |
jfmengels
reviewed
Sep 5, 2022
jfmengels
approved these changes
Sep 5, 2022
|
Looks good, thank you very much for your work and patience @miniBill 🙏 😊 |
|
Happy to have it merged ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #33