Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to extra-files.js #181

Closed
wants to merge 0 commits into from

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jun 26, 2024

Depends on #175.
Here's the diff as GH doesn't play well with stacks from forks: lishaduck/node-elm-review@bump-turbo...extra-files-types

@lishaduck lishaduck force-pushed the extra-files-types branch 2 times, most recently from f378dd6 to 777be1c Compare June 27, 2024 03:04
@jfmengels jfmengels closed this Jun 28, 2024
@jfmengels jfmengels force-pushed the extra-files-types branch from 777be1c to 6d5aa2c Compare June 28, 2024 15:12
@jfmengels
Copy link
Owner

I misdid the order of my Git operations, so it looks closed but this was merged 😄

Thanks for all the PRs @lishaduck!

@jfmengels
Copy link
Owner

Do you know if the remaining open PRs are still relevant or if I should close them?

@lishaduck
Copy link
Contributor Author

Do you know if the remaining open PRs are still relevant or if I should close them?

As in #132? I don't think it's still relevant. The Dependabot ones are probably fine if they're rebased. #147 could be closed, but until I've landed a replacement, I figure we might as well keep it open.

@lishaduck lishaduck mentioned this pull request Jun 28, 2024
@lishaduck lishaduck deleted the extra-files-types branch June 28, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants