Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberAxis3D.getTickLabelFormatter() never used? #4

Closed
ThomasDaheim opened this issue Sep 10, 2018 · 3 comments
Closed

NumberAxis3D.getTickLabelFormatter() never used? #4

ThomasDaheim opened this issue Sep 10, 2018 · 3 comments

Comments

@ThomasDaheim
Copy link

Hi,

I was trying to change to format of the tick label using NumberAxis3D.setTickLabelFormatter - with no results. No matter what I set here the format is always the same.

When checking, how the formatter is used in the library I get

Usages of NumberAxis3D.getTickLabelFormatter [no occurrences]                

so it seems that this feature isn't used at all?

@ThomasDaheim
Copy link
Author

Have to answer myself with some findings :-)

As I can see from debugging, my value of tickLabelFormatter gets overwritten in Chart3D.draw -> Chart3D.findAxisTickUnits -> NumberAxis3D.selectTick with the value of this.tickSelector.getCurrentTickLabelFormat(). No wonder my formats don't get used...

Unfortunately, I don't see any method for NumberTickSelector.setCurrentTickLabelFormat :-( So how could I change the format of the output?

ThomasDaheim added a commit to ThomasDaheim/orson-charts that referenced this issue Sep 11, 2018
Overwrite tickLabelFormatter only when not explicitly set by user
ThomasDaheim added a commit to ThomasDaheim/orson-charts that referenced this issue Sep 11, 2018
@ThomasDaheim
Copy link
Author

See my pull request for this one

@jfree
Copy link
Owner

jfree commented Oct 4, 2020

Hmm, looks like I applied your fix in the 2.0 release, should have updated this ticket. Thanks for pointing out the bug!

@jfree jfree closed this as completed Oct 4, 2020
jfree added a commit that referenced this issue Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants