Use cargo version -v instead of rustc -vV when obtaining host triple
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrimmel
reviewed
Sep 17, 2024
jfrimmel
reviewed
Sep 17, 2024
|
Thank you for your contribution! Can you adjust your code to make it build on the current MSRV? The two suggestions should be all it needs. |
when obtaining host triple. This fixes an issue where rustc cannot be found since the cargo and rustc binaries are in separate directories.
|
Thank you! Somehow GitHub won't let me run the CI on this specific PR. Someone proposed to close&re-open the PR. Therefore don't be scared when receiving a notification of a closed PR 😉 |
jfrimmel
added a commit
that referenced
this pull request
Sep 18, 2024
This was accidentally introduced with #77.
jfrimmel
added a commit
that referenced
this pull request
Sep 18, 2024
The previous code was cleaner, but is not yet supported on Rust 1.51. This was accidentally introduced with #77.
jfrimmel
added a commit
that referenced
this pull request
Sep 18, 2024
Follow-up to #77: make sure, that everything works with current MSRV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where rustc cannot be found since the cargo and rustc binaries are in separate directories.
You should probably fix the clippy lints!