fix clippy lints

src/driver.rs

@@ -39,8 +39,8 @@ pub fn driver() -> io::Result<bool> {
         .collect();
 
     /* convert to runner env variable */
-    let host = host.replace('-', "_").replace('.', "_").to_uppercase();
-    let runner = format!("CARGO_TARGET_{}_RUNNER", host);
+    let host = host.replace(['-', '.'], "_").to_uppercase();
+    let runner = format!("CARGO_TARGET_{host}_RUNNER");
 
     /* cargo run with a custom runner */
     let cargo_valgrind = env::args_os()

src/main.rs

@@ -55,7 +55,7 @@ fn display_error(errors: &[valgrind::xml::Error]) {
 fn main() {
     panic::replace_hook();
 
-    let number_of_arguments = || env::args_os().skip(0).count();
+    let number_of_arguments = || env::args_os().skip(1).count();
     let help_requested = || env::args_os().any(|arg| arg == "--help" || arg == "-h");
     let is_cargo_subcommand = || env::args_os().nth(1).map_or(false, |arg| arg == "valgrind");
     if number_of_arguments() == 0 || help_requested() {
@@ -79,7 +79,7 @@ fn main() {
             textwrap::Options::with_termwidth(),
         )
         .join("\n");
-        println!("{}", text);
+        println!("{text}");
     } else if is_cargo_subcommand() {
         if !driver::driver().expect("Could not execute subcommand") {
             process::exit(200);

src/panic.rs

@@ -7,6 +7,7 @@
 //! addition information is printed (e.g. for [`Error::MalformedOutput`]).
 //!
 //! [`Error::MalformedOutput`]: crate::valgrind::Error::MalformedOutput
+#![allow(clippy::module_name_repetitions)]
 
 use crate::valgrind::Error;
 use std::panic;
@@ -53,7 +54,7 @@ pub fn replace_hook() {
             textwrap::Options::with_termwidth(),
         )
         .join("\n");
-        eprintln!("{}", text);
+        eprintln!("{text}");
 
         eprintln!(
             "{}: version {}",
@@ -64,10 +65,7 @@ pub fn replace_hook() {
         // intentionally not wrapped using `textwrap`, since own formatting
         // might be applied.
         if let Some(Error::MalformedOutput(e, content)) = panic.payload().downcast_ref() {
-            eprintln!(
-                "XML format mismatch between `valgrind` and `cargo valgrind`: {}",
-                e
-            );
+            eprintln!("XML format mismatch between `valgrind` and `cargo valgrind`: {e}");
             eprintln!(
                 "XML output of valgrind:\n```xml\n{}```",
                 String::from_utf8_lossy(content)

src/valgrind/mod.rs

@@ -37,8 +37,8 @@ impl fmt::Display for Error {
             Self::ValgrindNotInstalled => write!(f, "valgrind executable not found"),
             Self::SocketConnection => write!(f, "local TCP I/O error"),
             Self::ProcessFailed => write!(f, "cannot start valgrind process"),
-            Self::ValgrindFailure(s) => write!(f, "invalid valgrind usage: {}", s),
-            Self::MalformedOutput(e, _) => write!(f, "unexpected valgrind output: {}", e),
+            Self::ValgrindFailure(s) => write!(f, "invalid valgrind usage: {s}"),
+            Self::MalformedOutput(e, _) => write!(f, "unexpected valgrind output: {e}"),
         }
     }
 }
@@ -60,7 +60,7 @@ where
 
     // additional options to pass to valgrind?
     if let Ok(additional_args) = env::var("VALGRINDFLAGS") {
-        valgrind.args(additional_args.split(" "));
+        valgrind.args(additional_args.split(' '));
     }
 
     let cargo = valgrind

src/valgrind/xml/mod.rs

@@ -141,7 +141,7 @@ impl Display for Frame {
             f.write_str(" (")?;
             f.write_str(file)?;
             if let Some(line) = self.line {
-                write!(f, ":{}", line)?;
+                write!(f, ":{line}")?;
             }
             f.write_str(")")?;
         }
@@ -168,6 +168,6 @@ impl<'de> Visitor<'de> for HexVisitor {
             .strip_prefix("0x")
             .ok_or_else(|| E::custom("'0x' prefix missing"))?;
         Self::Value::from_str_radix(value, 16)
-            .map_err(|_| E::custom(format!("invalid hex number '{}'", value)))
+            .map_err(|_| E::custom(format!("invalid hex number '{value}'")))
     }
 }

tests/cli.rs

@@ -20,7 +20,7 @@ fn leak_detected() {
 #[test]
 fn examples_are_runnable() {
     cargo_valgrind()
-        .args(&["run", "--example", "no-leak"])
+        .args(["run", "--example", "no-leak"])
         .args(TARGET_CRATE)
         .assert()
         .success()