Cleanup host-lookup in driver code #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code was very messy for multiple reasons: the code worked almost entirely with `Vec<u8>` (a.k.a. byte strings) instead of actual strings, and thus needed to perform all string operations by hand. The search was also linear (although the performance penalty is negligible in this case). Another bad thing is, that the code always executed the fallback path of querying `rustc -vV` even if the normal path would have worked (which are the majority of cases), therefore the code needed a redesign. This PR pulls the search over a specific command output out into its own function and runs the primary path first and only runs the fallback path if necessary. This makes the code much easier to read and under- stand. The new function also works on strings, making its implementation much simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code was very messy for multiple reasons: the code worked almost entirely with
Vec<u8>(a.k.a. byte strings) instead of actual strings, and thus needed to perform all string operations by hand. The search was also linear (although the performance penalty is negligible in this case). Another bad thing is, that the code always executed the fallback path of queryingrustc -vVeven if the normal path would have worked (which are the majority of cases), therefore the code needed a redesign.This PR pulls the search over a specific command output out into its own function and runs the primary path first and only runs the fallback path if necessary. This makes the code much easier to read and under- stand. The new function also works on strings, making its implementation much simpler.