Removed the dummy remote repository in favour for the snapshot and re… #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lease resolver repositories
|
Hi @markrekveld, we have several issues regarding this PR on some of our products, as reflected in the following: jfrog/jfrog-azure-devops-extension#381 jfrog/jenkins-artifactory-plugin#734 This required us to revert the changes. If you would like to improve this PR and contribute a fixing PR, we would greatly appreciate it. Thanks a lot. |
|
Hi @omerzi Thanks for letting me know, I'll update the PR and resubmit once done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dummy repository is added to allow for the resolution of depedencies using the jfrog cli resolver configuration for Maven. Some maven build plugins, like the
org.codehaus.mojo:versions-maven-pluginwill try to resolve artifacts using this dummy repository but will always fail.This PR implements a solution that allows maven build plugins to resolve artifacts using the jfrog cli resolver configuration by configuring the snapshot and release resolver repositories just like the ArtifactoryEclipseResolversHelper and ArtifactorySonatypeResolversHelper do.
Instead of configuring a dummy and "hoping" it gets proxied to resolver repositories.