Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xray]: Fixed the chart indentation issue that occurs when setting external RabbitMQ credentials #1968

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

grig777
Copy link

@grig777 grig777 commented Feb 22, 2025

PR Checklist

  • Chart Version bumped
  • CHANGELOG.md updated
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
The Helm chart templating, install or upgrade was failing when setting external credentials for RabbitMQ. The issue was caused by incorrect indentation in the generated YAML. An example configuration that previously broke templating:

rabbitmq:
  enabled: false
  external:
    url: '{{ include "xray.rabbitmq.extRabbitmq.url" . }}'
    secrets:
      username:
        name: xray-rabbitmq-creds
        key: username
      password:
        name: xray-rabbitmq-creds
        key: password
      url:
        name: xray-rabbitmq-creds
        key: url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant