Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xray]: Isolate Ipa replica count from the xray-statefulset replicaCo… #1969

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kobiShenkar
Copy link

@kobiShenkar kobiShenkar commented Feb 24, 2025

…unt to correlate replicaCountServer from xray-server-deployment

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
What this PR does - Adds an option to control the IPA replica count separately from the general .Values.replicaCount setting.

Why we need it:
When comparing xray-server-deployment and xray-ipa-deployment, it appears that a new key was introduced to manage server replica counts, but a similar option was not implemented for IPA replicas.
Current behavior:
xray-server-deployment:

  • if not .Values.autoscalingServer.enabled
    replicas: {{ .Values.replicaCountServer }}
  • end

xray-ipa-deployment:

  • if not .Values.autoscalingIpa.enabled
    replicas: {{ .Values.replicaCount }}
  • end

This update ensures consistent control over replica counts for both deployments.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

…unt to correlate replicaCountServer from xray-server-deployment
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Kobi Shenkar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@kobiShenkar
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant