Add Xray Source Control Service #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
sverdlov93
reviewed
Sep 12, 2023
sverdlov93
reviewed
Sep 12, 2023
sverdlov93
reviewed
Sep 12, 2023
utils/scandetails.go
Outdated
Comment on lines
206
to
209
| // In some VCS providers, there are no projects, fallback to the repository owner. | ||
| if gitProject == "" { | ||
| gitProject = sc.RepoOwner | ||
| } |
There was a problem hiding this comment.
Suggested change
| // In some VCS providers, there are no projects, fallback to the repository owner. | |
| if gitProject == "" { | |
| gitProject = sc.RepoOwner | |
| } |
sverdlov93
reviewed
Sep 12, 2023
utils/scandetails.go
Outdated
Comment on lines
194
to
197
| if err != nil { | ||
| log.Warn(fmt.Sprintf("failed getting latest commit, repository: %s, branch: %s. error: %s ", sc.RepoName, scannedBranch, err.Error())) | ||
| return | ||
| } |
sverdlov93
reviewed
Sep 12, 2023
utils/scandetails.go
Outdated
Comment on lines
202
to
204
| if err != nil { | ||
| log.Warn(fmt.Sprintf("failed getting repository information, for repository: %s, branch: %s. error: %s ", sc.RepoName, scannedBranch, err.Error())) | ||
| return |
Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com>
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
EyalDelarea
had a problem deploying
to
frogbot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating
GitInfoContextbefore scanning a project, and passes it to cli-core.In the case the user have XSC server enabled, scan results will be visible in the UI.
In case not, regular Xray flow will be executed.
Only
Scan-Repositorycommand sends theGitInfoContextasScan-Pull-Requestwill need extra fields.jfrog/jfrog-client-go#823
jfrog/jfrog-cli-core#940