Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor after Results changes in security-cli #724

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Refactor after Results changes in security-cli #724

wants to merge 19 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jul 23, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Depends on: jfrog/jfrog-cli-security#96

@attiasas attiasas added the ignore for release Automatically generated release notes label Jul 23, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 25, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 28, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 29, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 7, 2024
eranturgeman
eranturgeman reviewed Sep 5, 2024
View reviewed changes
scanrepository/scanrepository.go Outdated
@@ -155,7 +157,11 @@ func (cfp *ScanRepositoryCmd) scanAndFixProject(repository *utils.Repository) er
return err
}
if cfp.analyticsService.ShouldReportEvents() {
cfp.analyticsService.AddScanFindingsToXscAnalyticsGeneralEventFinalize(scanResults.CountScanResultsFindings())
if summary, err := conversion.NewCommandResultsConvertor(conversion.ResultConvertParams{}).ConvertToSummary(scanResults); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err is redeclared here

eranturgeman
eranturgeman reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I just want to understand how the multiple roots this is not missed due to recent changes

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 30, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 30, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman eranturgeman approved these changes

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @eranturgeman