Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR scan - Check difference between best common ancestor #728

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

attiasas
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

On Scan Pull Request command, we are preforming 2 scans.

  1. On target branch
  2. On source branch

After changes, we are now comparing the best common ancestor using git merge-base source target to determine the revision to compare the source against

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jul 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Jul 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 31, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 1, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 1, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant