Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show secrets detected at PR scan #793

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Show secrets detected at PR scan #793

merged 4 commits into from
Dec 5, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 2, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

Add an option to generate secrets comments in scan PR using JF_PR_SHOW_SECRETS_COMMENTS=true
image

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Dec 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 2, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas requested a review from hadarshjfrog December 3, 2024 11:19
@attiasas attiasas merged commit ff61ceb into jfrog:dev Dec 5, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog hadarshjfrog left review comments

@eranturgeman eranturgeman eranturgeman approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@attiasas @eranturgeman @hadarshjfrog