Add 'workingDirectory' parameter to the Generic Artifacts task #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Relates to jfrog/jfrog-cli#1846 |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
sverdlov93
reviewed
Apr 9, 2023
There was a problem hiding this comment.
Hi @flcdrg,
Thanks for your great contribution!
Please look at my following comments.
tests/package.json
Outdated
| @@ -8,6 +8,7 @@ | |||
| "main": "testUtils.ts", | |||
| "dependencies": { | |||
| "@jfrog/tasks-utils": "file:../jfrog-tasks-utils/jfrog-tasks-utils-1.0.0.tgz", | |||
| "@jfrog/test-utils": "file:", | |||
There was a problem hiding this comment.
what is the purpose behind that line?
There was a problem hiding this comment.
Not sure.. (I didn't add that myself, must have been tooling that did it)
|
Hi @flcdrg, |
|
yes, got caught up with other things :-) |
- Allows overriding the default working directory
Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com>
flcdrg
force-pushed
the
workingdir-for-generic-artifacts
branch
from
e67f463
to
e7498b6
Compare
|
Ready to review again |
|
Hi @flcdrg, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows overriding the default working directory
All tests passed. If this feature is not already covered by the tests, I added new tests.
This pull request is on the dev branch.
I used
npm run formatfor formatting the code before submitting the pull request.