Skip to content

Commit

Permalink
Resolve conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
eyalbe4 committed Aug 29, 2024
2 parents f62dd0c + 9f90ecd commit 233f8ab
Show file tree
Hide file tree
Showing 37 changed files with 1,808 additions and 949 deletions.
9 changes: 4 additions & 5 deletions artifactory/commands/buildinfo/publish.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ package buildinfo
import (
"errors"
"fmt"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/commands/commandssummaries"
"github.com/jfrog/jfrog-cli-core/v2/commandsummary"
"github.com/jfrog/jfrog-cli-core/v2/artifactory/utils/commandsummary"
"net/url"
"strconv"
"strings"
Expand Down Expand Up @@ -146,7 +145,7 @@ func (bpc *BuildPublishCommand) Run() error {
return err
}

if err = recordCommandSummary(buildInfo, buildLink, bpc.serverDetails.Url, majorVersion); err != nil {
if err = recordCommandSummary(buildInfo, buildLink); err != nil {
return err
}

Expand Down Expand Up @@ -232,12 +231,12 @@ func (bpc *BuildPublishCommand) getNextBuildNumber(buildName string, servicesMan
return strconv.Itoa(latestBuildNumber), nil
}

func recordCommandSummary(buildInfo *buildinfo.BuildInfo, buildLink, serverUrl string, majorVersion int) (err error) {
func recordCommandSummary(buildInfo *buildinfo.BuildInfo, buildLink string) (err error) {
if !commandsummary.ShouldRecordSummary() {
return
}
buildInfo.BuildUrl = buildLink
buildInfoSummary, err := commandsummary.New(commandssummaries.NewBuildInfo(serverUrl, majorVersion), "build-info")
buildInfoSummary, err := commandsummary.NewBuildInfoSummary()
if err != nil {
return
}
Expand Down
199 changes: 0 additions & 199 deletions artifactory/commands/commandssummaries/buildinfosummary.go

This file was deleted.

Loading

0 comments on commit 233f8ab

Please sign in to comment.