Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress bar race issue, and Improve UI #1207

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Fix progress bar race issue, and Improve UI #1207

merged 13 commits into from
Jul 24, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jul 22, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
Screen.Recording.2024-07-24.at.18.47.23.mov

@sverdlov93
unite actions
52c27b7 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Update progress bar dependency to latest Update progress bar dependency to latest (v8) Jul 22, 2024
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Jul 22, 2024
@sverdlov93
unite actions
e6042ee 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
d635320 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
deb1390 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Update progress bar dependency to latest (v8) Fix progress bar race issue, and Improve UX Jul 23, 2024
@sverdlov93 sverdlov93 changed the title Fix progress bar race issue, and Improve UX Fix progress bar race issue, and Improve UI Jul 23, 2024
@sverdlov93
unite actions
7fc5547 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from omerzi July 23, 2024 11:22
@sverdlov93
unite actions
d22d3b6 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from yahavi July 23, 2024 11:47
@sverdlov93
unite actions
12a5f59 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
bc64a8b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
12b61d1 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
54a1557 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
unite actions
05a311a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into up…
0f7c91d 
…date-progres

# Conflicts:
#	go.mod
@sverdlov93
unite actions
b02d383 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
yahavi
yahavi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@sverdlov93 sverdlov93 merged commit b86b307 into jfrog:dev Jul 24, 2024
6 of 7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@omerzi omerzi Awaiting requested review from omerzi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi