Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve progress spinner message #1213

Merged
merged 11 commits into from
Jul 25, 2024
Merged

Improve progress spinner message #1213

merged 11 commits into from
Jul 25, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jul 25, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Replace generic "working" message with specific one.
For upload command - uploading
For download command - downloading

@sverdlov93
improve
53c8315 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the base branch from master to dev July 25, 2024 11:02
@sverdlov93 sverdlov93 changed the title Improve upload/download command logs and progress Improve progress spinner message Jul 25, 2024
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Jul 25, 2024
@sverdlov93
improve
6a0fb7c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve
230c44b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from yahavi July 25, 2024 15:05
@sverdlov93
improve
25f5ace 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve
5ebb372 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve
86764be 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve
db6db8e 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit 980acf0 into jfrog:dev Jul 25, 2024
6 of 7 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sverdlov93 @eyalbe4 @yahavi