Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedded plugin context - don't set flags if not exists #1217

Merged
merged 10 commits into from
Jul 31, 2024
Merged

embedded plugin context - don't set flags if not exists #1217

merged 10 commits into from
Jul 31, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jul 30, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

For embedded plugins, when using its context flags where reported as set when they are not.
Fixing: (c *Context) IsFlagSet(flagName string) bool

@attiasas attiasas added the bug Something isn't working label Jul 30, 2024
@attiasas attiasas requested a review from RobiNino July 30, 2024 14:31
RobiNino
RobiNino requested changes Jul 30, 2024
View reviewed changes
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
RobiNino
RobiNino requested changes Jul 31, 2024
View reviewed changes
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
plugins/components/conversionlayer.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@RobiNino RobiNino merged commit 1b62823 into jfrog:dev Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobiNino RobiNino RobiNino requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @RobiNino