Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve artifacts links in command summaries #1221

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Aug 5, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Improvements:

  1. We clear filter on links to make sure the artifact is not masked and will be shown.
  2. Remove the projectKey query param to avoid conflict with repositories that are not part of the project.

@RobiNino RobiNino added the improvement Automatically generated release notes label Aug 5, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi August 5, 2024 07:41
@RobiNino RobiNino changed the title Clear filter in command summary links Improve artifacts links in command summaries Aug 5, 2024
@RobiNino RobiNino merged commit 0354bbe into jfrog:dev Aug 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants