Add MetaData service support #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osaidwtd
commented
Aug 11, 2024
osaidwtd
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
* Improve UI for scan command (jfrog#706) * Upgrade go version in go.mod to 1.20 (jfrog#732) * Fix lint issues found (jfrog#733) * Config transfer - ensure target not older than source (jfrog#721) * Update tests environment - nuget and dotnet to version 6 (jfrog#734) * Flatten audit graph (jfrog#736) * Use gradle-dep-tree with Audit (jfrog#719) --------- Co-authored-by: Sara Omari <114062096+sarao1310@users.noreply.github.com> Co-authored-by: Eyal Ben Moshe <eyalbenmoshe@jfrog.com> Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com> Co-authored-by: Yahav Itzhak <yahavi@users.noreply.github.com>
# Conflicts: # .github/workflows/analysis.yml # go.mod # go.sum # xray/audit/java/gradle.go # xray/commands/audit/generic/auditmanager.go
# Conflicts: # go.mod # go.sum
sverdlov93
reviewed
Aug 11, 2024
artifactory/utils/utils_test.go
Outdated
Comment on lines
65
to
77
| func TestCreateMetadataServiceManager(t *testing.T) { | ||
| testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if r.RequestURI == "api/v1/query" { | ||
| content := []byte(`{"query":"queryBody"}`) | ||
| _, err := w.Write(content) | ||
| assert.NoError(t, err) | ||
| } | ||
| })) | ||
| defer testServer.Close() | ||
| serviceManager, err := CreateMetadataServiceManager(&config.ServerDetails{MetadataUrl: testServer.URL + "/"}, false) | ||
| assert.NoError(t, err) | ||
| assert.NotEmpty(t, serviceManager) | ||
| } |
There was a problem hiding this comment.
this test doesn't check anything, it just creates a server without calling it. you can just avoid it as this is being tested by the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.