Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Summary - New UI #1245

Merged
merged 79 commits into from
Aug 29, 2024
Merged

Command Summary - New UI #1245

merged 79 commits into from
Aug 29, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Aug 26, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on

Introduce new UI to command summaries!

image

Including displaying scan results alongside published modules

@EyalDelarea
Implement both extended and basic test
fb2adf3
@EyalDelarea
Fix docker multi-arch view
5acc691
@EyalDelarea
full to extended
a3efa83
@EyalDelarea
Nest modules inside build info section
46c7f0b
@EyalDelarea
fix tests
348cfd1
@EyalDelarea
fix table
5a3c100
@EyalDelarea
Change bool location
e3fb69c
@EyalDelarea
Merge branch 'subscription-based-summary' into new_summary_ui
866e1ee 
# Conflicts:
#	artifactory/utils/commandsummary/buildinfosummary.go
#	artifactory/utils/commandsummary/buildinfosummary_test.go
@EyalDelarea
Fix tables
36647ac
@EyalDelarea
Move to static variables
0e1a410
@EyalDelarea
Fix unsued variables
d8e49c4
@EyalDelarea
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into su…
0e2aa2e 
…bscription-based-summary
@EyalDelarea
Fix tests
975f485
@EyalDelarea
Fix tests
189ce13
@EyalDelarea
Fix static check
060fe79
@EyalDelarea
Fix static check
02df2bc
@EyalDelarea
Fix static check
4e1151e
@EyalDelarea
Fix static check
5ee94d8
@EyalDelarea
pull dev
85f9bbc
@EyalDelarea
Update upgrade message
57af0a1
@EyalDelarea
Rename
9b129f9
@EyalDelarea
Fix tests with new link
b0f4cd4
@EyalDelarea
pull
9a93bfe
@EyalDelarea
Module id title
89ec77f
@EyalDelarea
Working table length
c4b1118
@EyalDelarea
Build info + maven module
fffd482
@EyalDelarea
Fix except docker multi view
e2c1e38
@EyalDelarea
Add correct width
791bbe6
@EyalDelarea
Comment out the build info summary tests until fix comparing issues
9100e8f
@EyalDelarea
Merge branch 'dev' into subscription-based-summary
2390106
@EyalDelarea EyalDelarea added new feature Automatically generated release notes improvement Automatically generated release notes and removed improvement Automatically generated release notes new feature Automatically generated release notes labels Aug 28, 2024
@EyalDelarea EyalDelarea marked this pull request as ready for review August 28, 2024 15:45
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@EyalDelarea EyalDelarea merged commit f38f696 into jfrog:dev Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @eyalbe4