Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use releases server-id from the environment variable #820

Merged

Conversation

asafgabai
Copy link
Contributor

@asafgabai asafgabai commented Jun 6, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

When the releases server is configured in an environment variable (JFROG_CLI_RELEASES_REPO), use the server-id configured in it instead of the one in the project's gradle-config.

…e the server-id configured in it instead of the one in the gradle-config.
@asafgabai asafgabai added the bug Something isn't working label Jun 6, 2023
@asafgabai asafgabai temporarily deployed to frogbot June 6, 2023 12:43 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

What is Frogbot?

@asafgabai asafgabai requested a review from omerzi June 6, 2023 12:51
@asafgabai asafgabai marked this pull request as ready for review June 6, 2023 12:52
Copy link
Member

@omerzi omerzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@asafgabai asafgabai temporarily deployed to frogbot June 11, 2023 07:31 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

What is Frogbot?

@asafgabai asafgabai merged commit aa725de into jfrog:dev Jun 11, 2023
@asafgabai asafgabai deleted the pheeks-reelices-cerver-aydee-phrom-aenv-bhar branch June 11, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants