Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer - Exclude transferring the repository props #837

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Transfer - Exclude transferring the repository props #837

merged 2 commits into from
Jun 25, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jun 25, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Setting properties directly on the repository itself doesn't serve any practical purpose. Additionally, replication involves setting properties on a repository, which we would like to avoid transferring to the target.

@yahavi yahavi added the improvement Automatically generated release notes label Jun 25, 2023
@yahavi yahavi requested a review from eyalbe4 June 25, 2023 09:55
@yahavi yahavi self-assigned this Jun 25, 2023
@yahavi yahavi requested a review from RobiNino June 25, 2023 10:51
@yahavi yahavi changed the title Transfer - Exclude setting the repository props Transfer - Exclude transferring the repository props Jun 25, 2023
@yahavi yahavi merged commit cd08ca2 into jfrog:dev Jun 25, 2023
1 check failed
@yahavi yahavi deleted the exclude-repo-props branch June 25, 2023 14:49
@p-linnane p-linnane mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@RobiNino RobiNino Awaiting requested review from RobiNino

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4