New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumping scan results to local dir #168

Merged

eranturgeman merged 15 commits into jfrog:dev from eranturgeman:dumping-scan-results-to-local-dir

Sep 15, 2024

Contributor

eranturgeman commented Sep 9, 2024 •

edited

Loading

The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....
All static analysis checks passed.
All tests have passed. If this feature is not already covered by the tests, new tests have been added.
All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR adds the following:

New flag for Audit command: --output-dir
This flags receives a url for a local repository in which all scans results will be kept in files (Sca + Jas)
adds a new functionality of dumping every scan result to a file in this directory, as soon as the scanner completes its execution

eranturgeman added 4 commits

September 9, 2024 12:03


          added new --output-dir flag to audit command + added insertion with v…

a424244

…alidation to auditCmd


          added scans output dir to auditParams and passed it to the scanners t…

…asks


          added scans output dir to auditParams and passed it to the scanners t…

a6b4f3c

…asks


          added a Dump Results functionality for Sca and Jas scanners and fixed…

7e2e68a

… all changes signatures

eranturgeman had a problem deploying to frogbot

September 9, 2024 09:19

— with

GitHub Actions Failure


          sets the new flag as hidden flag

5dba209

eranturgeman temporarily deployed to frogbot

September 9, 2024 09:22

— with

GitHub Actions Inactive

eranturgeman added new feature safe to test labels

github-actions bot removed the safe to test label


          minor test fix

a3dd160

eranturgeman temporarily deployed to frogbot

September 9, 2024 11:54

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label


          minor test fix

eranturgeman temporarily deployed to frogbot

September 9, 2024 12:00

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label


          integration test added to Audit with output dir + improved another te…

55356ea

…st in the same file

eranturgeman temporarily deployed to frogbot

September 9, 2024 15:41

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

eece33e

eranturgeman had a problem deploying to frogbot

September 9, 2024 15:43

— with

GitHub Actions Failure

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

fa6142a

eranturgeman temporarily deployed to frogbot

September 9, 2024 15:46

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

eranturgeman requested a review from attiasas

September 9, 2024 15:47

bb8b65c

eranturgeman temporarily deployed to frogbot

September 9, 2024 15:48

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

attiasas reviewed

View reviewed changes

Contributor

attiasas left a comment

Nice, check out my comments

cli/docs/flags.go Outdated Show resolved Hide resolved

utils/utils.go Outdated Show resolved Hide resolved

utils/utils.go Outdated Show resolved Hide resolved

commands/audit/audit_test.go Outdated Show resolved Hide resolved

eranturgeman added 2 commits

September 12, 2024 11:08


          Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…

f519376

…o dumping-scan-results-to-local-dir


          fixed CR comments

265ef38

eranturgeman temporarily deployed to frogbot

September 12, 2024 08:09

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label


          Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…

70bb13a

…o dumping-scan-results-to-local-dir

eranturgeman temporarily deployed to frogbot

September 15, 2024 06:48

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

attiasas approved these changes

View reviewed changes

commands/audit/scarunner.go Outdated Show resolved Hide resolved


          fix CR comment

7951b1a

eranturgeman temporarily deployed to frogbot

September 15, 2024 08:23

— with

GitHub Actions Inactive

eranturgeman added the safe to test label

github-actions bot removed the safe to test label

github-actions bot commented Sep 15, 2024

🐸 JFrog Frogbot

eranturgeman merged commit c7c5467 into jfrog:dev

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels