Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #2078

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add CONTRIBUTING.md #2078

merged 1 commit into from
Jul 14, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jul 14, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add a CONTRIBUTING.md file and reformat the pull request template.
Goals:

  • Make the README.md file clean from technical details.
  • Help contributors by pointing them directly to the CONTRIBUTING.md file. New contributed see a link to it once opening a Pull Request:
    image
  • Replace an unactionable guideline "All static analysis checks passed" in the pull request template with a requirement to run go vet ./....

Link to README: https://github.com/yahavi/jfrog-cli/tree/contributing#readme

@yahavi yahavi added the ignore for release Automatically generated release notes label Jul 14, 2023
@yahavi yahavi requested a review from eyalbe4 July 14, 2023 12:13
@yahavi yahavi self-assigned this Jul 14, 2023
@yahavi yahavi merged commit 95f6f4a into jfrog:dev Jul 14, 2023
9 of 10 checks passed
@yahavi yahavi deleted the contributing branch July 14, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants