Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve upload archive progress bar counter #1042

Merged
merged 107 commits into from
Nov 13, 2024
Merged

Improve upload archive progress bar counter #1042

merged 107 commits into from
Nov 13, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Nov 10, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Half the number of upload as zip by 2.
Avoid counting directories as uploaded files on progress bar.

Also fixed a failing test on repositories/terraform

sverdlov93 and others added 30 commits June 15, 2022 19:36
@sverdlov93
Update tests.yml
b742b6e
@sverdlov93
Update tests.yml
707d8b3
@omerzi
Promote version to 1.28.1 (jfrog#733)
a664ea4
@eyalbe4
Added the Frogbot badge to the README (jfrog#740)
0b22cb3
@sverdlov93
Merge remote-tracking branch 'upstream/dev' into masterupstream
93d1ee0 
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	utils/utils.go
#	xray/services/scan.go
#	xray/services/scan_test.go
@omerzi
Merge remote-tracking branch 'origin/dev'
60012f0
@eyalbe4
Merge branch 'dev'
72340a7
@talarian1
Merge remote-tracking branch 'origin/dev'
3c0e410
@omerzi
Merge remote-tracking branch 'origin/dev'
7dd161b
@talarian1
Merge remote-tracking branch 'origin/dev'
88f4c5c
@yahavi
Merge branch 'master' into dev
21b99ad
@yahavi
Promoted version to 1.29.1
b71c280
@eyalbe4
Merge branch 'dev'
8f7755c
@eyalbe4
Merge branch 'dev'
e6ba583
@RobiNino
Merge branch 'dev'
b624428
@omerzi
Merge branch 'master' into dev
da0c018
@omerzi
Promoted version to 1.31.1
f750025
@omerzi
Merge remote-tracking branch 'origin/dev'
e1d57bd 
# Conflicts:
#	utils/utils.go
@eyalbe4
Merge branch 'dev'
886ff5f
@eyalbe4
Promoted version to 1.31.3
b1ae836
@eyalbe4
Merge branch 'dev'
df38e23
@eyalbe4
Merge branch 'dev'
46b7fb9
@eyalbe4
Resolve conflicts
5f58723
@eyalbe4
Merge branch 'dev'
080ef1a
@attiasas
Merge branch 'dev'
7c244c5
@EyalDelarea
Merge branch 'master' into dev
6d1c9e7
@EyalDelarea
Merge remote-tracking branch 'origin/dev'
b3d917f
@sverdlov93
Merge remote-tracking branch 'upstream/dev'
3be412b
@RobiNino
Merge branch 'dev'
fa697b5
@eranturgeman
Merge remote-tracking branch 'origin/dev'
7b2943f
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@sverdlov93
Improve upload archive progress bar
54882c2 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@sverdlov93
Improve upload archive progress bar
740dce4 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@sverdlov93
Improve upload archive progress bar
741ec00 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@sverdlov93
Improve upload archive progress bar
ca91693 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 12, 2024
eyalbe4
eyalbe4 approved these changes Nov 13, 2024
View reviewed changes
artifactory/services/upload.go Outdated Show resolved Hide resolved
eyalbe4
eyalbe4 requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comment.

@sverdlov93
Improve upload archive progress bar
1fa037f 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit f0d689e into jfrog:dev Nov 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sverdlov93 @eyalbe4 @omerzi @talarian1 @yahavi @RobiNino @attiasas @EyalDelarea @eranturgeman