Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New usage reporting methods #807

Merged
merged 21 commits into from
Aug 28, 2023
Merged

New usage reporting methods #807

merged 21 commits into from
Aug 28, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Aug 6, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Improving usage reports by adding two new reporting usage methods:

  1. Using Xray API (from version 3.81.4)
  2. Using Ecosystem API - Usage service

Moved 'ValidateMinimumVersion' from core to this repository

@attiasas attiasas added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Aug 6, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 6, 2023
@attiasas attiasas changed the base branch from master to dev August 6, 2023 13:59
@attiasas attiasas temporarily deployed to frogbot August 8, 2023 12:10 — with GitHub Actions Inactive
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

@attiasas attiasas requested review from yahavi and eyalbe4 August 8, 2023 14:05
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@attiasas attiasas mentioned this pull request Aug 9, 2023
Merged
3 tasks
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 9, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 14, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 22, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 22, 2023
@attiasas attiasas requested a review from yahavi August 22, 2023 13:28
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 22, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 22, 2023
@attiasas attiasas mentioned this pull request Aug 23, 2023
Merged
4 tasks
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 23, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 23, 2023
@eyalbe4 eyalbe4 changed the title Add reporting usage methods New usage reporting methods Aug 27, 2023
eyalbe4
eyalbe4 requested changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I see @sverdlov93 reviewed this PR already, I didn't review it, but I did notice the following and shared my suggestions below.

utils/utils.go Outdated Show resolved Hide resolved
utils/utils.go Show resolved Hide resolved
yahavi
yahavi requested changes Aug 27, 2023
View reviewed changes
utils/usage/reportusage.go Outdated Show resolved Hide resolved
utils/usage/reportusage.go Outdated Show resolved Hide resolved
artifactory/usage/reportusage_test.go Outdated Show resolved Hide resolved
xray/usage/reportusage.go
}

func GetExpectedXrayEventName(productId, commandName string) string {
return "server_" + productId + "_" + commandName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have the "server_" prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested by the bi, all events in Xray that are not from the UI should have a prefix of "server_"

eyalbe4
eyalbe4 requested changes Aug 27, 2023
View reviewed changes
xray/usage/reportusage.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 28, 2023
@attiasas attiasas merged commit c6e6798 into jfrog:dev Aug 28, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@attiasas @eyalbe4 @yahavi @sverdlov93