Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic on temp file deletion #988

Merged
merged 18 commits into from
Aug 4, 2024
Merged

Avoid panic on temp file deletion #988

merged 18 commits into from
Aug 4, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jul 30, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

following @adityaramesh7 request

sverdlov93 and others added 11 commits July 25, 2024 13:58
@sverdlov93
docker repo build info
32f3ee9 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' into buildinfo-repo
d172324
@sverdlov93
Merge branch 'dev' into buildinfo-repo
9c0ffa2
@sverdlov93
improve
cc6ad62 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge remote-tracking branch 'sverdlov93/buildinfo-repo' into buildin…
0dcbcc4 
…fo-repo
@sverdlov93
improve
b61f6e3 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
revert minsplitsize
cb70b6a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
cacad6c 
…uildinfo-repo
@sverdlov93
avoid panic
38691cd 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
avoid panic
b975559 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-client-go into b…
b635796 
…uildinfo-repo
@sverdlov93 sverdlov93 changed the base branch from master to dev July 30, 2024 12:13
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jul 30, 2024
@sverdlov93 sverdlov93 requested a review from yahavi July 30, 2024 12:14
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 30, 2024
@sverdlov93
Use gofrog's crypto
5420ea0 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested a review from eyalbe4 August 1, 2024 09:09
eyalbe4
eyalbe4 requested changes Aug 1, 2024
View reviewed changes
utils/io/fileutils/temp_test.go Outdated Show resolved Hide resolved
utils/io/fileutils/temp.go Outdated Show resolved Hide resolved
utils/io/fileutils/temp.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Aug 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 1, 2024
@sverdlov93
Use gofrog's crypto
df7fe9b 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge remote-tracking branch 'sverdlov93/buildinfo-repo' into buildin…
9fe0795 
…fo-repo

# Conflicts:
#	go.mod
#	go.sum
@sverdlov93
Use gofrog's crypto
416227c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the bug Something isn't working label Aug 4, 2024
@sverdlov93
Use gofrog's crypto
3af9d79 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Use gofrog's crypto
788a707 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit f1e3266 into jfrog:dev Aug 4, 2024
3 of 4 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4