Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle plugin with Webpack #115

Merged
merged 2 commits into from
Aug 15, 2021
Merged

Bundle plugin with Webpack #115

merged 2 commits into from
Aug 15, 2021

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Aug 8, 2021

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Possibly resolves #109

Results:
Activation time drops by around 90% from ~300 to ~30.
Extension size drops from 2.6M to 366K

@yahavi yahavi requested a review from eyalbe4 August 8, 2021 09:25
@yahavi yahavi self-assigned this Aug 8, 2021
@yahavi yahavi merged commit 17f7d59 into jfrog:master Aug 15, 2021
@yahavi yahavi deleted the webpack branch August 15, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extension host terminated unexpectedly for Golang project
2 participants
@yahavi @eyalbe4